fix(sessions): show inline banner on cloud stream disconnect#2194
Open
thmsobrmlr wants to merge 1 commit into
Open
fix(sessions): show inline banner on cloud stream disconnect#2194thmsobrmlr wants to merge 1 commit into
thmsobrmlr wants to merge 1 commit into
Conversation
When the cloud SSE stream gives up after exhausted reconnect attempts, the task UI rendered a fullscreen error overlay on top of the already populated ConversationView, hiding all cached events. The session data was still in memory (and logs on disk), so the overlay was the only thing blocking access to the conversation. Plumb the existing `retryable` flag from CloudTaskErrorUpdate through the session store onto AgentSession. When `hasError && errorRetryable && events.length > 0`, render a small red banner above the conversation with the error title and a Retry button instead of the fullscreen overlay. Hard errors (no events yet, non-retryable) keep the existing overlay path. Generated-By: PostHog Code Task-Id: 0be36564-39e9-475b-8d1c-c74911ebecde
Contributor
|
Reviews (1): Last reviewed commit: "fix(sessions): show inline banner on clo..." | Re-trigger Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SessionViewwas painting a fullscreenabsolute inset-0error overlay on top of an already-renderedConversationView— hiding all the cached events even though session data is still in memory and logs are on disk.retryableflag fromCloudTaskErrorUpdatethroughservice.ts→sessionStore→useSessionViewState→SessionView.hasError && errorRetryable && events.length > 0, render a small redCloudStreamDisconnectedBannerabove the conversation with title, message, and Retry button. Otherwise (hard errors, no events yet, non-retryable failures), keep the existing fullscreen overlay.Testing
tried locally (just wait 15+ min with any task selected and then click into another cloud task)